Fix ppl describe bug #612 #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es schema.catalog.table Signed-off-by: YANGDB <[email protected]>
…es schema.catalog.table Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha and
kaituo
as code owners
YANG-DB
added
Lang:PPL
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* fix describe ppl command to be aware of 3 parts FQN table that includes schema.catalog.table Signed-off-by: YANGDB <[email protected]> * fix describe ppl command to be aware of 3 parts FQN table that includes schema.catalog.table Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> (cherry picked from commit 0be5697) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-656-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0be56974238ef2f7d88f21fed4ce4fd40681d756
# Push it to GitHub
git push --set-upstream origin backport/backport-656-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexusThen, create a pull request where the |
LantaoJin
reviewed
Sep 14, 2024
| @@ -132,6 +132,11 @@ public LogicalPlan visitRelation(Relation node, CatalystPlanContext context) { | |||
| identifier = new TableIdentifier( | |||
| node.getTableQualifiedName().getParts().get(1), | |||
| Option$.MODULE$.apply(node.getTableQualifiedName().getParts().get(0))); | |||
| } else if (node.getTableQualifiedName().getParts().size() == 3) { | |||
There was a problem hiding this comment.
Seems the assumption here is relation names cannot contain .. But unfortunately, index name can contain ., ref https://opensearch.org/docs/latest/api-reference/index-apis/create-index/
YANG-DB
pushed a commit
that referenced
this pull request
Sep 16, 2024
* fix describe ppl command to be aware of 3 parts FQN table that includes schema.catalog.table * fix describe ppl command to be aware of 3 parts FQN table that includes schema.catalog.table --------- (cherry picked from commit 0be5697) Signed-off-by: YANGDB <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix describe ppl command to be aware of 3 parts FQN table that includes
schema.catalog.tableIssues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.