Ppl patterns command #627
Merged
Ppl patterns command #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha and
kaituo
as code owners
Signed-off-by: YANGDB <[email protected]>
YANG-DB
added
Lang:PPL
Signed-off-by: YANGDB <[email protected]>
LantaoJin
reviewed
Sep 10, 2024
| * @return list of names of the derived fields | ||
| */ | ||
| public static List<String> getNamedGroupCandidates(String pattern) { | ||
| public static List<String> getNamedGroupCandidates(String pattern, Map<String, Literal> arguments) { |
There was a problem hiding this comment.
Minor: Seems you are unifying the method signature. Why not add some abstract methods in ParseExpression just like parseValue does? Otherwise, the current class ParseExpression is too simple and unnecessary.
There was a problem hiding this comment.
I'll completely remove the class hierarchy and remain with a simple functional composition
…R comments feedback Signed-off-by: YANGDB <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* add patterns support & tests Signed-off-by: YANGDB <[email protected]> * update tests Signed-off-by: YANGDB <[email protected]> * remove unrelated Dockerfile Signed-off-by: YANGDB <[email protected]> * sbt format Signed-off-by: YANGDB <[email protected]> * fix ParseUtils and simplify different pase expressions according to PR comments feedback Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> (cherry picked from commit fd3f82f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-627-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fd3f82fc16273d47f17aa47e699aeaa8b4c3679d
# Push it to GitHub
git push --set-upstream origin backport/backport-627-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexusThen, create a pull request where the |
YANG-DB
pushed a commit
that referenced
this pull request
Sep 11, 2024
* add patterns support & tests * update tests * remove unrelated Dockerfile * sbt format * fix ParseUtils and simplify different pase expressions according to PR comments feedback --------- (cherry picked from commit fd3f82f) Signed-off-by: YANGDB <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add patterns command using the next OpenSearch PPL functionality
Do you have any additional context?
Issues Resolved
#462
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.