-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conf for specifying flint checkpoint location #577
Merged
noCharger
merged 2 commits into
opensearch-project:main
from
noCharger:add-checkpointlocation-conf
Aug 21, 2024
Merged
Add conf for specifying flint checkpoint location #577
noCharger
merged 2 commits into
opensearch-project:main
from
noCharger:add-checkpointlocation-conf
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
August 19, 2024 20:40
Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
add-checkpointlocation-conf
branch
from
August 19, 2024 21:00
b7652a8
to
79d00cd
Compare
flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSparkIndexBuilder.scala
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSparkIndexBuilder.scala
Show resolved
Hide resolved
...g-test/src/integration/scala/org/opensearch/flint/spark/FlintSparkCoveringIndexITSuite.scala
Show resolved
Hide resolved
vamsimanohar
approved these changes
Aug 21, 2024
noCharger
added
backport 0.5-nexus
backport 0.5
0.5
enhancement
New feature or request
labels
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Add conf for specifying flint checkpoint location Signed-off-by: Louis Chu <[email protected]> * Add IT and public doc Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 5c190b3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-577-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5c190b3891852013bf983c923af18537c4e302ca
# Push it to GitHub
git push --set-upstream origin backport/backport-577-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus Then, create a pull request where the |
noCharger
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Add conf for specifying flint checkpoint location * Add IT and public doc --------- (cherry picked from commit 5c190b3) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Add conf for specifying flint checkpoint location Signed-off-by: Louis Chu <[email protected]> * Add IT and public doc Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 5c190b3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Add conf for specifying flint checkpoint location * Add IT and public doc --------- (cherry picked from commit 5c190b3) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conf for specifying a default checkpoint location to be re-used for index creation
Issues Resolved
#102
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.