Add ppl-spark-extension optimzer support & mvn publish #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the PPL add ppl-spark-extension jar mvn publish Signed-off-by: YANGDB <[email protected]>
…test") disabled the Optimization rules during the IT Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo and
anirudha
as code owners
YANG-DB
changed the title
vmmusings
reviewed
Oct 3, 2023
ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/FlintPPLSuite.scala
Outdated
Show resolved
Hide resolved
vmmusings
reviewed
Oct 3, 2023
integ-test/src/test/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLTimeWindowITSuite.scala
Show resolved
Hide resolved
…to include both flint & ppl to verify they can interact independently Signed-off-by: YANGDB <[email protected]>
vmmusings
approved these changes
Oct 4, 2023
dai-chen
reviewed
Oct 4, 2023
| .set(SQLConf.OPTIMIZER_EXCLUDED_RULES.key, ConvertToLocalRelation.ruleName) | ||
| .set( | ||
| "spark.sql.extensions", | ||
| List(classOf[FlintPPLSparkExtensions].getName, classOf[FlintSparkExtensions].getName) |
There was a problem hiding this comment.
FlintSparkExtensions is accessible to ppl module?
There was a problem hiding this comment.
This is used only in the integ-test project which is depended on both flint & ppl plugins
PPL module is not dependent on flint module
dai-chen
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add optimizer support for flint based acceleration queries - also using the PPL
add ppl-spark-extension jar mvn publish
Issues Resolved
#55
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.