Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh policy back to WAIT_FOR other than writing query result #554

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Aug 9, 2024

Description

  • Fix refresh policy back to WAIT_FOR other than writing query result
  • Those are fixed in Use refresh policy from config #530 , but should not be changed since it could break due to eventual consistency. In actual use case, AOSS doesn't need to write to other than result and index(MV/CV/SK)

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 marked this pull request as ready for review August 9, 2024 22:39
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: my understanding is we need to make sure refresh policy is set to WAIT_FOR in Spark job before we deploy this in Flint 0.5, right? Otherwise, the refresh policy of writing to result index becomes NONE?

@ykmr1224
Copy link
Collaborator Author

Just to confirm: my understanding is we need to make sure refresh policy is set to WAIT_FOR in Spark job before we deploy this in Flint 0.5, right? Otherwise, the refresh policy of writing to result index becomes NONE?

That's right.

@penghuo penghuo merged commit def26cf into opensearch-project:main Aug 12, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 12, 2024
…554)

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit def26cf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: why it takes longer after this change? Previously it was around 40-45 mins and now it's around 1 hour?

penghuo pushed a commit that referenced this pull request Aug 12, 2024
…554) (#557)

(cherry picked from commit def26cf)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az pushed a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants