Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statement timeout #539

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Aug 7, 2024

Description

  1. Add statement timeout, the dependency change is merged Add timeout StatementState sql#2724
  2. Fix SessionStates to align with https://github.com/opensearch-project/sql/blob/b2403ca4fa1bbba2a1ac8827b6f7aeefe48f9f32/async-query-core/src/main/java/org/opensearch/sql/spark/execution/session/SessionState.java#L18-L21
  3. Move data model from flint.data to flint.common.model

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger force-pushed the add-statement-timeout branch 3 times, most recently from 977e2c3 to 0b6769c Compare August 7, 2024 23:02
@noCharger noCharger marked this pull request as ready for review August 7, 2024 23:06
@noCharger noCharger force-pushed the add-statement-timeout branch from 0b6769c to 484fdaa Compare August 8, 2024 00:12
Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger force-pushed the add-statement-timeout branch from 484fdaa to e11abc3 Compare August 8, 2024 00:30
@noCharger noCharger added the 0.5 label Aug 8, 2024
@noCharger noCharger self-assigned this Aug 8, 2024
@noCharger noCharger force-pushed the add-statement-timeout branch from f258018 to c306090 Compare August 8, 2024 21:56
@noCharger noCharger requested a review from dai-chen August 8, 2024 22:10
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Please double check and test with SQL plugin later.

@noCharger noCharger force-pushed the add-statement-timeout branch from c306090 to 949c654 Compare August 9, 2024 18:19
@noCharger noCharger merged commit e99fdb6 into opensearch-project:main Aug 9, 2024
4 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2024
* Add statement timeout

Signed-off-by: Louis Chu <[email protected]>

* Revert c306090 and make state always lowercase

Signed-off-by: Louis Chu <[email protected]>

---------

Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit e99fdb6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants