Add config on query loop execution frequency #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
force-pushed
the
query-loop-freq
branch
2 times, most recently
from
fc027c7 to
cc07c77
Compare
Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
query-loop-freq
branch
from
cc07c77 to
40d2c08
Compare
noCharger
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Aug 6, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Show resolved
Hide resolved
integ-test/src/integration/scala/org/apache/spark/sql/FlintREPLITSuite.scala
Outdated
Show resolved
Hide resolved
integ-test/src/integration/scala/org/apache/spark/sql/FlintREPLITSuite.scala
Outdated
Show resolved
Hide resolved
noCharger
force-pushed
the
query-loop-freq
branch
3 times, most recently
from
aa6b51e to
7e5db68
Compare
Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
query-loop-freq
branch
from
7e5db68 to
4345b16
Compare
dai-chen
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With default query loop execution frequency there are 3 min session idle time and 30000 / 100 = 300 additional calls to check queries waiting in the loop.
For example, on sanity IT, there are 5000 / 100 = 50 calls theoretically, and in actuality 47 calls due to the actual query execution time.
On new IT "query loop should exit with inactivity timeout due to large query loop frequency," there should be no subsequent calls because the loop waits 5 seconds, which is deemed inactivity.
Issues Resolved
#397
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.