handle MetaException with glue AccessDeniedException #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
noCharger
commented
Jul 3, 2024
Comment on lines
492
to
493
| if (rootCauseClassName == "org.apache.hadoop.hive.metastore.api.MetaException" && | ||
| errMsg.contains("com.amazonaws.services.glue.model.AccessDeniedException")) { |
There was a problem hiding this comment.
Use class name string here since hadoop.hive.metastore is not imported as a dependency of spark-hive jar
|
LGTM. but check the build failure. |
…xception properly Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
handle-metaexception
branch
from
5c9144f to
21afd04
Compare
dai-chen
reviewed
Jul 3, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
Fixed. Failed due to flint-commons refactor, will need a manual backport |
vamsimanohar
approved these changes
Jul 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
* handleGeneralException should handle MetaException with AccessDeniedException properly Signed-off-by: Louis Chu <[email protected]> * Revise comments Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit b5715f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
added a commit
that referenced
this pull request
Jul 4, 2024
…412) * handle MetaException with glue AccessDeniedException (#410) * handleGeneralException should handle MetaException with AccessDeniedException properly Signed-off-by: Louis Chu <[email protected]> * Revise comments Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit b5715f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Resolve cherry-pick confict Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Chu <[email protected]>
noCharger
added a commit
to noCharger/opensearch-spark
that referenced
this pull request
Aug 3, 2024
…ect#410) * handleGeneralException should handle MetaException with AccessDeniedException properly Signed-off-by: Louis Chu <[email protected]> * Revise comments Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handleGeneralException should handle MetaException with AccessDeniedException properly
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.