support shard level split on read path #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
penghuo
requested review from
dai-chen,
rupal-bq,
vmmusings,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Jul 5, 2024
| * @param query DSL query. DSL query is null means match_all | ||
| * @return {@link FlintReader}. | ||
| */ | ||
| FlintReader createReader(String indexName, String shardId, String query); |
There was a problem hiding this comment.
Is shardId concept binding to FlintOpenSearchClient implementation or generic?
There was a problem hiding this comment.
We can abstract this task/split info later.
| * @param metadata | ||
| * Metadata of the table. | ||
| */ | ||
| case class OpenSearchTable(tableName: String, metadata: Map[String, FlintMetadata]) { |
There was a problem hiding this comment.
Is using FlintMetadata temporary for only fetching index setting? Or is there hard dependency between OS table and Flint index in future?
There was a problem hiding this comment.
only for index setting and mapping, not binding to real index
dai-chen
approved these changes
Jul 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test
preference:_shard:paramaters.Benchmark
Single Index with 5 shards
The table below presents the p90 query latency results for both the partitioned and non-partitioned test cases. Across all queries, the results with partitioning show significantly lower times compared to the non-partitioned results.
logs-181998logs-181998WHERE status <> 0;logs-181998;logs-181998;@timestamp), MAX(@timestamp) FROM dev.default.logs-181998;Multiple Indices, each index has 5 shards
The table below presents the p90 query latency results for both the partitioned and non-partitioned test cases when query index wildcard. Across all queries, the results with partitioning show significantly lower times compared to the non-partitioned results.
Issues Resolved
#396
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.