Unquote text and identifiers in PPL parsing #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <[email protected]>
seankao-az
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Jun 26, 2024
integ-test/src/test/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLBasicITSuite.scala
Outdated
Show resolved
Hide resolved
...est/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanBasicQueriesTranslatorTestSuite.scala
Outdated
Show resolved
Hide resolved
ppl-spark-integration/src/main/java/org/opensearch/sql/common/utils/StringUtils.java
Show resolved
Hide resolved
ykmr1224
reviewed
Jun 26, 2024
ppl-spark-integration/src/main/java/org/opensearch/sql/common/utils/StringUtils.java
Show resolved
Hide resolved
integ-test/src/test/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLBasicITSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
ykmr1224
reviewed
Jun 27, 2024
Signed-off-by: Sean Kao <[email protected]>
dai-chen
approved these changes
Jun 27, 2024
ykmr1224
approved these changes
Jun 27, 2024
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Aug 9, 2024
* unquote text and identifiers in PPL parsing Signed-off-by: Sean Kao <[email protected]> * clean PPL suite comments Signed-off-by: Sean Kao <[email protected]> * fix PPL suite typo Signed-off-by: Sean Kao <[email protected]> * parameterize test cases Signed-off-by: Sean Kao <[email protected]> * add UT for StringUtils Signed-off-by: Sean Kao <[email protected]> * use JUnit 4 Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #33 , StringUtils is copied from sql repo to ppl-spark-integration
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.