Support custom metadata log service implementation #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
seankao-az
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
penghuo
reviewed
Jun 21, 2024
...re/src/main/scala/org/opensearch/flint/core/metadata/log/FlintMetadataLogServiceBuilder.java
Show resolved
Hide resolved
seankao-az
force-pushed
the
service-builder
branch
from
e8f3e86 to
c83b667
Compare
penghuo
approved these changes
Jun 21, 2024
...re/src/main/scala/org/opensearch/flint/core/metadata/log/FlintMetadataLogServiceBuilder.java
Show resolved
Hide resolved
seankao-az
force-pushed
the
service-builder
branch
from
c83b667 to
4f40bc1
Compare
Signed-off-by: Sean Kao <[email protected]>
seankao-az
force-pushed
the
service-builder
branch
from
4f40bc1 to
95b7a9d
Compare
This reverts commit 95b7a9d. Signed-off-by: Sean Kao <[email protected]>
Signed-off-by: Sean Kao <[email protected]>
noCharger
reviewed
Jun 24, 2024
| * <p> | ||
| * Custom implementations of {@link FlintMetadataLogService} are expected to provide a public | ||
| * constructor with the signature {@code public MyCustomService(SparkConf sparkConf)} to be | ||
| * instantiated by this builder. | ||
| */ | ||
| public class FlintMetadataLogServiceBuilder { |
There was a problem hiding this comment.
should FlintMetadataLogServiceBuilder moved to common as well?
There was a problem hiding this comment.
no this needs access to FlintOpenSearchMetadataLogService
...re/src/main/scala/org/opensearch/flint/core/metadata/log/FlintMetadataLogServiceBuilder.java
Show resolved
Hide resolved
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Aug 9, 2024
…t#389) * reflection to build metadata log service Signed-off-by: Sean Kao <[email protected]> * move common interface to flint-commons Signed-off-by: Sean Kao <[email protected]> * remove unused failLogEntry Signed-off-by: Sean Kao <[email protected]> * fix test Signed-off-by: Sean Kao <[email protected]> * scalafmtAll Signed-off-by: Sean Kao <[email protected]> * change service from interface to abstract class Signed-off-by: Sean Kao <[email protected]> * Revert "change service to abstract class" This reverts commit 95b7a9d. Signed-off-by: Sean Kao <[email protected]> * add javadoc for metadata log service constructor Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlintMetadataLogServiceBuilderto support custom implementation ofFlintMetadataLogServiceSparkConffor such builderFlintMetadataLogServicean abstract class with a constructor usingSparkConfFlintMetadataLog,FlintMetadataLogEntry,FlintMetadataLogService,OptimisticTransactionfailLogEntryfromFlintMetadataLogEntry(no access to org.opensearch.index namespace). Can add back in next PR when storage is abstracted away from the commonFlintMetadataLogEntryIssues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.