Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Introduce flint-commons for models and interfaces #373

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Jun 10, 2024

Description

  • [Refactor] Introduce flint-data for models and interfaces
    • Full details [RFC] Flint main class refactor #376
    • This PR will only move FlintCommand and FlintInstance
    • Other interfaces will be updated continously: For example, SessionManager and CommandLifecycleManager will go next, then FlintMetadataLogEntry, FlintMetadataLogService, etc
  • A new jar will be assembled flint-data-assembly-0.5.0-SNAPSHOT.jar

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger force-pushed the feature-interface-jar branch from 3fc11c1 to 2f37f4c Compare June 10, 2024 21:52
@noCharger noCharger requested a review from ykmr1224 June 10, 2024 21:52
@noCharger noCharger force-pushed the feature-interface-jar branch from 2f37f4c to 2f5e715 Compare June 10, 2024 21:55
Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger force-pushed the feature-interface-jar branch from cb7501c to b51406c Compare June 10, 2024 23:49
@noCharger noCharger self-assigned this Jun 11, 2024
@noCharger noCharger added 0.5 maintenance Code refactoring labels Jun 11, 2024
@dai-chen
Copy link
Collaborator

Just read issue #376 for context.
IMHO, flint-data is confusing and not sure what we plan to put into this module in future.
Any better name? At the moment, the module is more like Flint session model?

build.sbt Outdated Show resolved Hide resolved
@noCharger
Copy link
Collaborator Author

noCharger commented Jun 11, 2024

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger requested a review from vmmusings June 11, 2024 19:42
@vmmusings
Copy link
Member

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

flint-commons can be a good name....but we need to define what the responsibility of the module.

Signed-off-by: Louis Chu <[email protected]>
@noCharger
Copy link
Collaborator Author

Just read issue #376 for context. IMHO, flint-data is confusing and not sure what we plan to put into this module in future. Any better name? At the moment, the module is more like Flint session model?

What is the rationale behind naming flintData? It seems to suggest to have all the related model classes, but it does have behavior classes.

@dai-chen @vamsi-amazon The primary goal is to provide a shared library that allows for easier extension. So maybe flint-common or flint-utils, any suggestions?

flint-commons can be a good name....but we need to define what the responsibility of the module.

Thanks, update the responsibility in readme

@noCharger noCharger changed the title [Refactor] Introduce flint-data for models and interfaces [Refactor] Introduce flint-commons for models and interfaces Jun 11, 2024
@noCharger noCharger merged commit 80d8f6e into opensearch-project:main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5 maintenance Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants