-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index state stuck in refreshing when streaming job exits early #370
Merged
dai-chen
merged 4 commits into
opensearch-project:main
from
dai-chen:fix-index-state-stuck-when-streaming-job-exit-early
Jun 10, 2024
Merged
Fix index state stuck in refreshing when streaming job exits early #370
dai-chen
merged 4 commits into
opensearch-project:main
from
dai-chen:fix-index-state-stuck-when-streaming-job-exit-early
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
penghuo
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
spark-sql-application/src/main/scala/org/apache/spark/sql/JobOperator.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
vamsimanohar,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
June 7, 2024 20:51
Signed-off-by: Chen Dai <[email protected]>
dai-chen
force-pushed
the
fix-index-state-stuck-when-streaming-job-exit-early
branch
from
June 7, 2024 23:48
a1e809f
to
14df017
Compare
noCharger
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
) * Handle streaming job exit early case Signed-off-by: Chen Dai <[email protected]> * Modify IT to simplify Signed-off-by: Chen Dai <[email protected]> * Address PR comments Signed-off-by: Chen Dai <[email protected]> * Add more IT Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]> (cherry picked from commit 5460acc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen
pushed a commit
that referenced
this pull request
Jun 10, 2024
) (#374) * Handle streaming job exit early case * Modify IT to simplify * Address PR comments * Add more IT --------- (cherry picked from commit 5460acc) Signed-off-by: Chen Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Verified the changes with more test:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed the issue that streaming job already exits before
awaitMonitor
API called and updated Flint index state toFAILED
.Note that I'm unable to reproduce this issue in IT and doubt the the delay between execute SQL query and await monitor is caused by result index write. For DDL statement, although the result is empty, we write it by DataFrame with Flint data source instead of using OpenSearch client directly. Need to confirm this and will create issue separately.
Issues Resolved
#368
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.