-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Flint Spark API error reporting with centralized handler #348
Merged
dai-chen
merged 16 commits into
opensearch-project:main
from
dai-chen:improve-error-handling
Jun 27, 2024
Merged
Enhance Flint Spark API error reporting with centralized handler #348
dai-chen
merged 16 commits into
opensearch-project:main
from
dai-chen:improve-error-handling
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
commented
May 22, 2024
...ark-integration/src/main/scala/org/opensearch/flint/spark/FlintSparkTransactionSupport.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
vmmusings,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
June 26, 2024 16:52
Signed-off-by: Chen Dai <[email protected]>
dai-chen
changed the title
Enhance Flint error handling with detailed exception messages
Enhance Flint Spark API error reporting with centralized handler
Jun 26, 2024
penghuo
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.4 0.4
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.4
# Create a new branch
git switch --create backport/backport-348-to-0.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c1ec6bdf9258cf98595ade985c8d38b7b540114
# Push it to GitHub
git push --set-upstream origin backport/backport-348-to-0.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.4 Then, create a pull request where the |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #335, we enhanced error messages by storing the root cause error messages in the query results, helping users better understand issues. However, in Flint Spark's API layer, we still don't pass the underlying exceptions to the high-level code.
This PR introduces the
withTransaction
method to centralize logging and exception handling across different index operations and pass back the original exception. This change aims to improve the clarity of error reporting throughout the system.Testing
Index State Doesn't Satisfy Precondition
Tested index state exception for #201:
OpenSearch Exception
Tested OpenSearch exception for #252:
Wrong MV Query
Tested MV with wrong query in definition for #140
Spark log example
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.