Move query from entry point to SparkConf #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chu <[email protected]>
noCharger
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Mar 11, 2024
flint-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala
Show resolved
Hide resolved
dai-chen
approved these changes
Mar 12, 2024
Yes, it's pending for review opensearch-project/sql#2519 |
penghuo
reviewed
Mar 12, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJob.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
penghuo
reviewed
Mar 13, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
penghuo
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the query parameter from the entry point's main() arguments to SparkConf for batch and streaming jobs. There is no effect on interactive jobs other than removing the dummy query from the arg, which always reads from the request index.
Breaking change - together with opensearch-project/sql#2519
Issues Resolved
opensearch-project/sql#2376
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.