-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flint log format #263
Conversation
f1b2f83
to
5cf4ac2
Compare
Hi |
49b13d7
to
e85c8dc
Compare
* | ||
*/ | ||
@Plugin(name = "CustomJsonLayout", category = "Core", elementType = Layout.ELEMENT_TYPE, printObject = true) | ||
public class CustomJsonLayout extends AbstractStringLayout { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- do we need custom json layout? can we leverage Log4j json layout? https://logging.apache.org/log4j/2.x/manual/json-template-layout.html
- can we leverage Log4j env lookup for domain_name, client_id? https://logging.apache.org/log4j/2.x/manual/lookups.html#EnvironmentLookup
Propose a new log format following OTEL convention
|
Nice ! |
Signed-off-by: Louis Chu <[email protected]>
Signed-off-by: Louis Chu <[email protected]>
e85c8dc
to
67614f1
Compare
67614f1
to
525726b
Compare
Signed-off-by: Louis Chu <[email protected]>
525726b
to
d37ada5
Compare
Description
Standardize Flint log output format:
Usage V2
CustomLogging
classIssues Resolved
#235
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.