Use alternative ARN as credentials when configured #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
…ode" This reverts commit 159137e. Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Feb 29, 2024
| val REPL_FLINT_ASSUME_SESSION_ROLE_ARN = | ||
| FlintConfig("spark.repl.flint.ASSUME_ROLE_CREDENTIALS_ROLE_ARN") | ||
| .datasourceOption() | ||
| .doc("The role to use for writing state information to the session index. " + |
There was a problem hiding this comment.
Could you update user manual as well? Btw, this doesn't seem to only apply to REPL. It's used by low level Flint client? Should we follow spark.datasource.flint prefix?
| @@ -133,4 +133,8 @@ public String getPassword() { | |||
| public int getSocketTimeoutMillis() { | |||
| return Integer.parseInt(options.getOrDefault(SOCKET_TIMEOUT_MILLIS, String.valueOf(DEFAULT_SOCKET_TIMEOUT_MILLIS))); | |||
| } | |||
|
|
|||
| public String getSessionIndexARN() { | |||
| return options.getOrDefault("spark.repl.flint.ASSUME_ROLE_CREDENTIALS_ROLE_ARN", ""); | |||
|
Dropping this PR for adding a POC for OSS first, will revisit after the POC is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optionally, a user can specify an ARN which will be used for credentials in REPL, instead of the default provider.
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.