Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flint metrics #255

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Feb 15, 2024

Description

Metrics included in this PR:

request.metadata.read.2xx.count
request.metadata.read.4xx.count
request.metadata.read.5xx.count
request.metadata.read.403.count

request.metadata.write.2xx.count
request.metadata.write.4xx.count
request.metadata.write.5xx.count
request.metadata.write.403.count

request.metadata.heartbeat.failed.count

result.metadata.write.2xx.count
result.metadata.write.4xx.count
result.metadata.write.5xx.count
result.metadata.write.403.count

"streaming.running.count";
"streaming.failed.count";
"streaming.success.count";
"streaming.heartbeat.failed.count";
  1. Revised jobType values; allow default values when not defined.
  2. Changed all "running" metrics from counter to gauge, as the counter only reports delta.
  3. Refactored methods for metrics recording logic
  4. Added metrics on request/result metadata and streaming.
Screenshot 2024-02-16 at 1 12 53 PM

Screenshot 2024-02-19 at 12 14 14 PM

Screenshot 2024-02-19 at 12 15 05 PM

Issues Resolved

#117

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger force-pushed the add-more-flint-metrics branch 3 times, most recently from f43a597 to 464e64b Compare February 16, 2024 21:03
@noCharger noCharger marked this pull request as ready for review February 16, 2024 21:06
@noCharger noCharger force-pushed the add-more-flint-metrics branch 2 times, most recently from 7875d7e to dd1a0d6 Compare February 18, 2024 22:47
@noCharger noCharger force-pushed the add-more-flint-metrics branch from dd1a0d6 to 01ecd3a Compare February 18, 2024 23:21
@noCharger noCharger force-pushed the add-more-flint-metrics branch from b404542 to f73ebcd Compare February 19, 2024 17:16
@penghuo
Copy link
Collaborator

penghuo commented Feb 19, 2024

result.metadata.write.2xx.count
result.metadata.write.4xx.count
result.metadata.write.5xx.count
result.metadata.write.403.count

does InstanceRole required?

@noCharger
Copy link
Collaborator Author

result.metadata.write.2xx.count
result.metadata.write.4xx.count
result.metadata.write.5xx.count
result.metadata.write.403.count

does InstanceRole required?

There are no dimensions by default. Users can configure dimensions for their own purposes with #238. If we want to drop dimensions on a group of metrics, we need to support metric groups and group policy concepts, which are up for discussion.

Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger force-pushed the add-more-flint-metrics branch from 0b56cf9 to 3504a31 Compare February 20, 2024 00:11
@noCharger noCharger requested a review from penghuo February 20, 2024 15:27
@penghuo penghuo merged commit be8cb32 into opensearch-project:main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants