-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive job metrics #240
Conversation
0ee42e7
to
89ca72c
Compare
Signed-off-by: Louis Chu <[email protected]>
89ca72c
to
df05518
Compare
Signed-off-by: Louis Chu <[email protected]>
which option is preferred? option1 and option2? |
option1 which taken in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the dimension of these metrics?
* | ||
* @param metricName The name of the metric counter to be decremented. | ||
*/ | ||
public static void decrementCounter(String metricName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by definition, A counter is a cumulative metric that represents a single monotonically increasing counter whose value can only increase or be reset to zero on restart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by definition, A counter is a cumulative metric that represents a single monotonically increasing counter whose value can only increase or be reset to zero on restart.
Not sure about Prometheus, decrementing is possible with the Spark metrics library: https://metrics.dropwizard.io/4.2.0/manual/core.html#Counters
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
flint-core/src/main/java/org/opensearch/flint/core/metrics/MetricsUtil.java
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
Description
Metrics included in this PR:
There are two options to calculate session and statement metrics:
Option 1 (taken in this PR): Utilizes direct instrumentation, offering simplicity. However, it lacks resilience against manual modifications to request/result indices by users.
Option 2: Implements asynchronous data retrieval from the request index, ensuring data integrity from the primary source. This introduces additional overhead and dependency, given the external nature of the index.
Issues Resolved
#117
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.