-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support on-demand incremental refresh #234
Merged
dai-chen
merged 14 commits into
opensearch-project:main
from
dai-chen:support-on-demand-incremental-refresh-rebased
Feb 8, 2024
Merged
Support on-demand incremental refresh #234
dai-chen
merged 14 commits into
opensearch-project:main
from
dai-chen:support-on-demand-incremental-refresh-rebased
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
changed the title
Support on-demand incremental manual refresh
Support on-demand incremental refresh
Jan 24, 2024
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
January 26, 2024 07:29
penghuo
reviewed
Feb 7, 2024
...t-spark-integration/src/main/scala/org/opensearch/flint/spark/refresh/AutoIndexRefresh.scala
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
penghuo
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support on-demand incremental index refresh which is a new index refresh mode. Please check updated user manual for more details:
Code Changes
Most of the changed files are UT and IT. Reviewer can focus on the following changes:
FlintSparkIndexOptions
: added a newincremental_refresh
option with default False valueFlintSpark
: refactored complexdoRefresh()
method by the newFlintSparkIndexRefresh
abstraction and its subclassAutoIndexRefresh
andFullIndexRefresh
IncrementalIndexRefresh
: added this subclass for new incremental modeClass Diagram
Example
Create test table and skipping index with
incremental_refresh = true
:At this moment, Flint index is empty with incremental refresh option stored in metadata:
Trigger incremental refresh:
Insert more source data and trigger refresh again:
Issues Resolved
#195
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.