-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimensions to cloudwatch metric and metric filter option for CWSink. #176
Conversation
Signed-off-by: Vamsi Manohar <[email protected]>
what is the relationship of metrics dimension and screenshot?
|
Let me change the PR description.
|
@@ -59,6 +59,8 @@ lazy val flintCore = (project in file("flint-core")) | |||
exclude ("org.apache.logging.log4j", "log4j-api"), | |||
"com.amazonaws" % "aws-java-sdk" % "1.12.397" % "provided" | |||
exclude ("com.fasterxml.jackson.core", "jackson-databind"), | |||
"com.amazonaws" % "aws-java-sdk-cloudwatch" % "1.12.593" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance this can be provided
or not?
meanwhile I'm just thinking any impact on open source user who use Flint as library. Does all classes added have to be in Flint core module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Provided is not working...cloudwatch is not available.
- I still didn't get the idea behind flint-core,[I only see OS Client] should I one more package as flint-common-utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There won't be any impact to opensource user. We emit metrics but nothing will be pushed unless one configures a sink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Provided is not working...cloudwatch is not available.
- I still didn't get the idea behind flint-core,[I only see OS Client] should I one more package as flint-common-utils?
For now we only have FlintOpenSearchClient
. We may add FlintFileSystemClient
later (for storing Flint index data on S3). I was thinking for user who use Flint library in their own application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even for them we are actually providing benefit by giving out metrics similar to driver and executor metrics. CWSink they can leverage if they wish, otherwise they can ignore. We can discuss offline on this and will post the summary over here.
Description
--conf spark.metrics.conf.*.sink.cloudwatch.regex=.*Flint.*
property would publish only metrics with the regex Given.Usage of Dimensioned Name for below image:
Tested on emr-serverless by publishing dummy metrics.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.