Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Logging for Job Cleanup and Reduce REPL Inactivity Timeout #160

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Nov 16, 2023

Description

  • Added detailed logging to improve visibility during streaming job cleanup.
  • Decreased REPL job inactivity timeout from 30 to 10 minutes..

Tested manually to ensure new logs are correctly displayed during streaming job cleanup.

Issues Resolved

#157

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…Timeout

- Added detailed logging to improve visibility during streaming job cleanup.
- Decreased REPL job inactivity timeout from 30 to 10 minutes..

Tested manually to ensure new logs are correctly displayed during streaming job cleanup.

Signed-off-by: Kaituo Li <[email protected]>
Signed-off-by: Kaituo Li <[email protected]>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Just minor comment that could you add some info logging when we shutting down thread pool and stopping SparkContext? thinking maybe helpful if we know the shutdown code actually runs. Thanks!

@kaituo
Copy link
Collaborator Author

kaituo commented Nov 17, 2023

Thanks for the changes!

Just minor comment that could you add some info logging when we shutting down thread pool and stopping SparkContext? thinking maybe helpful if we know the shutdown code actually runs. Thanks!

added more logging. Also reused JobOperator in FlintREPL as well.

@kaituo kaituo merged commit 8dc9584 into opensearch-project:main Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants