query rewrite for LogsTable skipping index #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <[email protected]>
seankao-az
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
seankao-az
changed the title
penghuo
reviewed
Nov 14, 2023
| indexScan | ||
| .filter(new Column(indexFilter.get)) | ||
| .select(FILE_PATH_COLUMN) | ||
| .collect |
There was a problem hiding this comment.
collect is reduce operation, @dai-chen could you help sean fix this
There was a problem hiding this comment.
Discussed with Sean that this requires changes in LogsTable.
Similar as Flint FileIndex implementation:
- It accepts indexScan
DataFrameinstead of resultSet - It triggers the data frame
collectat execution time
@seankao-az correct me if I understood wrong.
There was a problem hiding this comment.
That's right. Need changes in LogsTable side. Right now LogsTable accepts a list of file ids. Should let it accept DataFrame instead.
There was a problem hiding this comment.
Done. Integration tested locally together with changes from dependency package.
seankao-az
changed the title
dai-chen
reviewed
Nov 14, 2023
...ration/src/main/scala/org/opensearch/flint/spark/skipping/ApplyFlintSparkSkippingIndex.scala
Outdated
Show resolved
Hide resolved
dai-chen
approved these changes
Nov 14, 2023
Signed-off-by: Sean Kao <[email protected]>
seankao-az
force-pushed
the
nexus-skipping
branch
from
2c33440 to
deb5fe8
Compare
penghuo
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query rewrite for LogsTable skipping index
Build skipping index
Process for building skipping index is unchanged due to compatibility of current method with LogsTable.
Query rewrite for skipping index
On query plan optimization time, we construct a new LogsTable with the DataFrame to fetch log file ids from skipping index. These log file ids are then used to build the scan operator.
Dependency
Added a compile time dependency which contains only the interface of LogsTable.
Test
Test is not possible without loading LogsConnectorSpark fat jar as dependency. Instead, manual integration test is done locally.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.