Handle Missing jobStartTime in JSON Deserialization #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
anirudha and
YANG-DB
as code owners
- Added handling for scenarios where jobStartTime is not present in the JSON input. - Ensures FlintInstance deserialization remains robust and error-free even when jobStartTime is missing. Testing: 1. Extended unit tests to cover the new case. 2. Conducted manual sanity tests to ensure stability and correctness. Signed-off-by: Kaituo Li <[email protected]>
penghuo
reviewed
Nov 14, 2023
| @@ -24,7 +24,7 @@ class FlintInstance( | |||
| var state: String, | |||
| val lastUpdateTime: Long, | |||
| // We need jobStartTime to check if HMAC token is expired or not | |||
penghuo
reviewed
Nov 14, 2023
| @@ -75,7 +78,13 @@ object FlintInstance { | |||
| val jobId = scalaSource("jobId").asInstanceOf[String] | |||
| val sessionId = scalaSource("sessionId").asInstanceOf[String] | |||
| val lastUpdateTime = scalaSource("lastUpdateTime").asInstanceOf[Long] | |||
| val jobStartTime = scalaSource("jobStartTime").asInstanceOf[Long] | |||
| // Safely extract 'jobStartTime' considering potential null or absence | |||
Signed-off-by: Kaituo Li <[email protected]>
penghuo
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing:
Issues Resolved
#152
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.