Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix, handle close scroll exception #136

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Nov 7, 2023

Description

  1. enforce wait_for for all write operation.
  2. fix bug when close timeout scroll. [BUG] RestHighLevelClient#clearScroll error: Unable to parse response body OpenSearch#11121

Issues Resolved

  1. [BUG] Enforce refresh_policy = wait_for when write result and state. #132

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

client.clearScroll(clearScrollRequest, RequestOptions.DEFAULT);
}
} catch (OpenSearchStatusException e) {
// OpenSearch throw exception if scroll already closed. https://github.com/opensearch-project/OpenSearch/issues/11121
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the exception message in the log so that we have a way to debug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. 71ccd85

I thought it is an OpenSearch bug.

Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo merged commit 5abdffc into opensearch-project:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants