-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info in Flint metadata log #125
Merged
penghuo
merged 11 commits into
opensearch-project:main
from
dai-chen:fix-metadatalog-entry-issues
Nov 7, 2023
Merged
Add more info in Flint metadata log #125
penghuo
merged 11 commits into
opensearch-project:main
from
dai-chen:fix-metadatalog-entry-issues
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
vamsimanohar,
penghuo and
anirudha
as code owners
November 7, 2023 04:27
Signed-off-by: Chen Dai <[email protected]>
penghuo
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR incorporates the follow-up minor changes below around recently added Flint metadata log and optimistic transaction in PR #110
New Changes
jobStartTime
: this won't be update until auto refresh restart by RECOVER commandBug Fixes
latestId
: this fixes the drop index failurelastUpdateTime
to Long type: earlier it was double quoted when create doc by mistakeImprovements
scheduleWithFixedDelay()
API insteadDELETED
state: in case that index is logical deleted and user wants to recreate after they delete index data manuallyCleanup
Testing
Creating index with latest Flint metadata format (cover 1, 2, 3)
jobStartTime
stay the same andlastUpdateTime
will be updated constantly:Both
jobStartTime
andlastUpdateTime
changes after recoveer:Logical deleted index can be recreated if user deletes index data and checkpoint manually (cover 6)
Simulate logical delete by drop index statement. Previous index state doc should be reused by create statement.
Issues Resolved
#123
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.