Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Refactor Catalyst visitor to match AST Builder composition #851

Closed
YANG-DB opened this issue Oct 31, 2024 · 0 comments
Closed

[FEATURE]Refactor Catalyst visitor to match AST Builder composition #851

YANG-DB opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
0.6 enhancement New feature or request Lang:PPL Pipe Processing Language support

Comments

@YANG-DB
Copy link
Member

YANG-DB commented Oct 31, 2024

Is your feature request related to a problem?
We would like to refactor the CatalystQueryPlanVisitor and separate it into two distinct visitors:

  • Plan Visitor ( which extends AbstractNodeVisitor<LogicalPlan, CatalystPlanContext> )
  • Expression Visitor (which extends AbstractNodeVisitor<Expression, CatalystPlanContext>)

This would match the existing PPL AST visitors composition:

  • AstBuilder ( which extends OpenSearchPPLParserBaseVisitor)
  • AstExpressionBuilder ( which extends OpenSearchPPLParserBaseVisitor )

In addition unify the ppl utils classes to match one of the following naming:

  • *Transformer - transforms PPL (logical) expressions into Spark (logical) expressions
  • *Utils - utility class

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@YANG-DB YANG-DB added enhancement New feature or request Lang:PPL Pipe Processing Language support 0.6 labels Oct 31, 2024
@YANG-DB YANG-DB self-assigned this Oct 31, 2024
@YANG-DB YANG-DB removed the untriaged label Oct 31, 2024
@YANG-DB YANG-DB closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6 enhancement New feature or request Lang:PPL Pipe Processing Language support
Projects
None yet
Development

No branches or pull requests

1 participant