Address comments

Signed-off-by: Tomoyuki Morita <[email protected]>
opensearch-project · Aug 29, 2024 · c144f8d · c144f8d
1 parent eeaf680
commit c144f8d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/flint-core/src/main/scala/org/opensearch/flint/core/FlintOptions.java b/flint-core/src/main/scala/org/opensearch/flint/core/FlintOptions.java
@@ -100,7 +100,9 @@ public class FlintOptions implements Serializable {
   public static final String CUSTOM_FLINT_METADATA_LOG_SERVICE_CLASS = "customFlintMetadataLogServiceClass";
 
   public static final String CUSTOM_FLINT_INDEX_METADATA_SERVICE_CLASS = "customFlintIndexMetadataServiceClass";
-  public static final String CUSTOM_QUERY_METADATA_SERVICE = "spark.flint.job.customFlintIndexMetadataServiceClass";
+
+  // TODO: This is POC specific
+  public static final String CUSTOM_QUERY_METADATA_SERVICE = "spark.flint.job.customQueryMetadataServiceClass";
 
   public FlintOptions(Map<String, String> options) {
     this.options = options;
@@ -188,6 +190,7 @@ public String getCustomCommandLifecycleManager() {
     return options.getOrDefault(CUSTOM_COMMAND_LIFECYCLE_MANAGER, "org.apache.spark.sql.CommandLifecycleManagerImpl");
   }
 
+  // TODO: This is POC specific
   public String getCustomQueryMetadataService() {
     return options.getOrDefault(CUSTOM_QUERY_METADATA_SERVICE, "org.apache.spark.sql.NoOpQueryMetadataService");
   }

diff --git a/...t-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala b/...t-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala
@@ -210,7 +210,7 @@ object FlintSparkConf {
       .createOptional()
   val QUERY_ID =
     FlintConfig(s"spark.flint.job.queryId")
-      .doc("Flint session id")
+      .doc("Flint query id")
       .createOptional()
   val REQUEST_INDEX =
     FlintConfig(s"spark.flint.job.requestIndex")
@@ -243,6 +243,7 @@ object FlintSparkConf {
     FlintConfig("spark.flint.job.customQueryResultWriter")
       .createOptional()
 
+  // TODO: This is POC specific
   val CUSTOM_QUERY_METADATA_SERVICE =
     FlintConfig(FlintOptions.CUSTOM_QUERY_METADATA_SERVICE)
       .createWithDefault("org.apache.spark.sql.NoOpQueryMetadataService")