address comments

Signed-off-by: Peng Huo <[email protected]>
opensearch-project · Sep 28, 2023 · 6e4842d · 6e4842d
1 parent d6ce91e
commit 6e4842d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/index.md b/docs/index.md
@@ -271,7 +271,7 @@ In the index mapping, the `_meta` and `properties`field stores meta and schema i
 - `spark.datasource.flint.host`: default is localhost.
 - `spark.datasource.flint.port`: default is 9200.
 - `spark.datasource.flint.scheme`: default is http. valid values [http, https]
-- `spark.datasource.flint.auth`: default is false. valid values [false, sigv4, basic]
+- `spark.datasource.flint.auth`: default is noauth. valid values [noauth, sigv4, basic]
 - `spark.datasource.flint.auth.username`: basic auth username.
 - `spark.datasource.flint.auth.password`: basic auth password.
 - `spark.datasource.flint.region`: default is us-west-2. only been used when auth=sigv4

diff --git a/flint-core/src/main/scala/org/opensearch/flint/core/FlintOptions.java b/flint-core/src/main/scala/org/opensearch/flint/core/FlintOptions.java
@@ -27,7 +27,7 @@ public class FlintOptions implements Serializable {
 
   public static final String AUTH = "auth";
 
-  public static final String NONE_AUTH = "false";
+  public static final String NONE_AUTH = "noauth";
 
   public static final String SIGV4_AUTH = "sigv4";
 

diff --git a/...t-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala b/...t-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala
@@ -51,7 +51,8 @@ object FlintSparkConf {
 
   val AUTH = FlintConfig("spark.datasource.flint.auth")
     .datasourceOption()
-    .doc("authentication type. supported value: NONE_AUTH(false), SIGV4_AUTH(sigv4), BASIC_AUTH")
+    .doc("authentication type. supported value: " +
+      "noauth(no auth), sigv4(sigv4 auth), basic(basic auth)")
     .createWithDefault(FlintOptions.NONE_AUTH)
 
   val USERNAME = FlintConfig("spark.datasource.flint.auth.username")