Fix qualified mv name check

Signed-off-by: Chen Dai <[email protected]>
opensearch-project · Oct 18, 2023 · 2778d68 · 2778d68
1 parent 1bfce3b
commit 2778d68
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/...integration/src/main/scala/org/opensearch/flint/spark/mv/FlintSparkMaterializedView.scala b/...integration/src/main/scala/org/opensearch/flint/spark/mv/FlintSparkMaterializedView.scala
@@ -141,7 +141,9 @@ object FlintSparkMaterializedView {
    *   Flint index name
    */
   def getFlintIndexName(mvName: String): String = {
-    require(mvName.contains("."), "Full table name database.mv is required")
+    require(
+      mvName.split("\\.").length >= 3,
+      "Qualified materialized view name catalog.database.mv is required")
 
     s"flint_${mvName.replace(".", "_")}"
   }

diff --git a/...ration/src/test/scala/org/opensearch/flint/spark/mv/FlintSparkMaterializedViewSuite.scala b/...ration/src/test/scala/org/opensearch/flint/spark/mv/FlintSparkMaterializedViewSuite.scala
@@ -40,11 +40,12 @@ class FlintSparkMaterializedViewSuite extends FlintSuite {
     mv.name() shouldBe "flint_spark_catalog_default_mv"
   }
 
-  test("should fail if not full MV name") {
-    val mv = FlintSparkMaterializedView("mv", "SELECT 1", Map.empty)
-    assertThrows[IllegalArgumentException] {
-      mv.name()
-    }
+  test("should fail if get name with unqualified MV name") {
+    the[IllegalArgumentException] thrownBy
+      FlintSparkMaterializedView("mv", testQuery, Map.empty).name()
+
+    the[IllegalArgumentException] thrownBy
+      FlintSparkMaterializedView("default.mv", testQuery, Map.empty).name()
   }
 
   test("get metadata") {