Update SDKRestClient/OpenSearchAsync client with http.port setting from OpenSearch during intialization #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… opensearch node settings with the source node address and HTTP port Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
joshpalis
requested review from
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
6 tasks
ryanbogan
previously approved these changes
May 26, 2023
vibrantvarun
previously approved these changes
May 26, 2023
…than from extension intialization request Signed-off-by: Joshua Palis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
============================================
+ Coverage 43.39% 43.57% +0.17%
- Complexity 312 314 +2
============================================
Files 69 69
Lines 1975 1983 +8
Branches 138 141 +3
============================================
+ Hits 857 864 +7
Misses 1101 1101
- Partials 17 18 +1
|
dbwiddis
approved these changes
May 26, 2023
src/main/java/org/opensearch/sdk/handlers/ExtensionsInitRequestHandler.java
Show resolved
Hide resolved
ryanbogan
approved these changes
May 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
…om OpenSearch during intialization (#788) * Modifies extension initialization request handling, updates sdkclient opensearch node settings with the source node address and HTTP port Signed-off-by: Joshua Palis <[email protected]> * Resetting test TransportAddress port to 9300 Signed-off-by: Joshua Palis <[email protected]> * pulling http.port settings from environment settings response rather than from extension intialization request Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit e18aaf6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
May 26, 2023
…om OpenSearch during intialization (#788) (#790) * Modifies extension initialization request handling, updates sdkclient opensearch node settings with the source node address and HTTP port * Resetting test TransportAddress port to 9300 * pulling http.port settings from environment settings response rather than from extension intialization request --------- (cherry picked from commit e18aaf6) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retrieves
http.portsetting from the environment settings response to update the opensearch node settings of the extension.yml, updates the SDKRestClient/OpenSearchAsyncClient with the opensearch http host retrieved from theNode.javaenvironment settings.See comment for more context : #782 (comment)
Issues Resolved
Part of #782
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.