Don't change Extension REST client Settings with transport node info #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
============================================
- Coverage 43.81% 43.39% -0.43%
+ Complexity 314 312 -2
============================================
Files 69 69
Lines 1990 1975 -15
Branches 139 138 -1
============================================
- Hits 872 857 -15
+ Misses 1102 1101 -1
- Partials 16 17 +1
|
owaiskazi19
approved these changes
May 25, 2023
vibrantvarun
approved these changes
May 25, 2023
ryanbogan
approved these changes
May 25, 2023
|
Are we ok with merging despite the slight codecov decrease? |
Well, that's weird because:
I looked into the specific changes. The lost coverage is that the new settings here are never actually used/tested: - .put(OPENSEARCH_HOST_SETTING, extensionSettings.getOpensearchAddress())
- .put(OPENSEARCH_PORT_SETTING, extensionSettings.getOpensearchPort())But they were removed alerady here: https://github.com/opensearch-project/opensearch-sdk-java/pull/783/files So codecov is using a different base. |
|
Seems Codecov is one commit behind main.
|
|
Ok, seems like we can just merge it in then |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
…786) Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit ba15d56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
May 25, 2023
…786) (#787) (cherry picked from commit ba15d56) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the line of code from #730 that updates Extension Settings in the SDK (used for REST connections) based on the OpenSearch node from initialization (used for Transport connections)
Issues Resolved
Part of ongoing work on #782. See comment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.