Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add default Opensearch host and port if init comes from localhost (#763)" #783

Merged
merged 1 commit into from
May 24, 2023

Conversation

joshpalis
Copy link
Member

This reverts commit aa8886d.

Issues Resolved

#782

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #783 (72cb83f) into main (579c302) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

❗ Current head 72cb83f differs from pull request most recent head ecf2e6e. Consider uploading reports for the commit ecf2e6e to get more accurate results

@@             Coverage Diff              @@
##               main     #783      +/-   ##
============================================
- Coverage     43.81%   43.47%   -0.35%     
+ Complexity      314      313       -1     
============================================
  Files            69       69              
  Lines          1990     1976      -14     
  Branches        139      138       -1     
============================================
- Hits            872      859      -13     
+ Misses         1102     1101       -1     
  Partials         16       16              
Impacted Files Coverage Δ
...main/java/org/opensearch/sdk/ExtensionsRunner.java 75.72% <ø> (-0.24%) ⬇️
...rch/sdk/handlers/ExtensionsInitRequestHandler.java 100.00% <100.00%> (+2.38%) ⬆️

@owaiskazi19 owaiskazi19 merged commit 3518f57 into opensearch-project:main May 24, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-783-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3518f57b53a9c5eb5712404d47e9797483080eab
# Push it to GitHub
git push --set-upstream origin backport/backport-783-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-783-to-1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants