Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Execute remote actions on another extension #606

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport ebc684a from #588.

* Add ProxyAction with TransportAction and handlers

Signed-off-by: Daniel Widdis <[email protected]>

* Give SDKActionModule a copy of ExtensionsRunner to use with transport

Signed-off-by: Daniel Widdis <[email protected]>

* Add new ProxyActionRequest

Signed-off-by: Daniel Widdis <[email protected]>

* Add SDKTransportService wrapper accessible to actions

Signed-off-by: Daniel Widdis <[email protected]>

* Implement ProxyTransportAction

Signed-off-by: Daniel Widdis <[email protected]>

* Add test case to HelloWorldExtension

Signed-off-by: Daniel Widdis <[email protected]>

* Better naming of ExtensionActionResponse and correct action name

Signed-off-by: Daniel Widdis <[email protected]>

* Refactoring with TransportService and latest OpenSearch PR updates

Signed-off-by: Daniel Widdis <[email protected]>

* Add ExtensionsActionRequestHandler

Signed-off-by: Daniel Widdis <[email protected]>

* Instantiate Proxy Action Request

Signed-off-by: Daniel Widdis <[email protected]>

* Working test case!

Signed-off-by: Daniel Widdis <[email protected]>

* Properly parse returned byte array into a response

Signed-off-by: Daniel Widdis <[email protected]>

* Add sequence diagram to DESIGN.md

Signed-off-by: Daniel Widdis <[email protected]>

* Typoo fix

Signed-off-by: Daniel Widdis <[email protected]>

* Update with latest changes on companion PR

Signed-off-by: Daniel Widdis <[email protected]>

* Rename ProxyFoo to RemoteExtensionFoo

Signed-off-by: Daniel Widdis <[email protected]>

* Better handling of response bytes

Signed-off-by: Daniel Widdis <[email protected]>

* Handle plugin remote action requests

Signed-off-by: Daniel Widdis <[email protected]>

* Address code review comments

Signed-off-by: Daniel Widdis <[email protected]>

* Update sequence diagram

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit ebc684a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis
Copy link
Member

Gradle check needs 2.x backport PR of opensearch-project/OpenSearch#6734

@owaiskazi19 owaiskazi19 merged commit c247b38 into 1.x Mar 30, 2023
@owaiskazi19 owaiskazi19 deleted the backport/backport-588-to-1.x branch March 30, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants