Created EngineExtension with default implementation from EnginePlugin #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varuntumbe <[email protected]>
varuntumbe
requested review from
CEHENKLE,
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
Signed-off-by: varuntumbe <[email protected]>
|
Er, spoke too soon, looks like spotless is complaining about something. :( (Extra line break) |
Signed-off-by: varuntumbe <[email protected]>
|
Yep I think its best to run the spotlessApply before every commit |
dbwiddis
approved these changes
Jan 31, 2023
I have a single key macro for "gradle spotlessapply check". :) |
|
Will take some time for #319 , I need to read and understand ExtensionManager class and will ask questions If I get stuck understanding the code |
saratvemulapalli
approved these changes
Jan 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
…#393) * Added EngineExtension Interface Signed-off-by: varuntumbe <[email protected]> * deleting the depreciated method Signed-off-by: varuntumbe <[email protected]> * spotlessApply has been done Signed-off-by: varuntumbe <[email protected]> (cherry picked from commit d622f72) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Feb 3, 2023
…#393) (#410) * Added EngineExtension Interface Signed-off-by: varuntumbe <[email protected]> * deleting the depreciated method Signed-off-by: varuntumbe <[email protected]> * spotlessApply has been done Signed-off-by: varuntumbe <[email protected]> (cherry picked from commit d622f72) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…opensearch-project#393) * Added EngineExtension Interface Signed-off-by: varuntumbe <[email protected]> * deleting the depreciated method Signed-off-by: varuntumbe <[email protected]> * spotlessApply has been done Signed-off-by: varuntumbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: varuntumbe [email protected]
Description
Add a new interface EngineExtension with default implementations for extension points matching EnginePlugin.java.
Issues Resolved
#323
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.