Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added High Level Rest Client for SDK #306

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

owaiskazi19
Copy link
Member

Signed-off-by: Owais Kazi [email protected]

Description

Added High Level Rest Client for SDK

Issues Resolved

Part of #294 and #302

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <[email protected]>
build.gradle Outdated Show resolved Hide resolved
src/main/java/org/opensearch/sdk/SDKClient.java Outdated Show resolved Hide resolved
src/main/java/org/opensearch/sdk/SDKClient.java Outdated Show resolved Hide resolved
src/main/java/org/opensearch/sdk/SDKClient.java Outdated Show resolved Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19 owaiskazi19 requested a review from dbwiddis January 6, 2023 18:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #306 (18971a6) into main (850fcb2) will decrease coverage by 0.25%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #306      +/-   ##
============================================
- Coverage     73.22%   72.97%   -0.26%     
- Complexity      117      120       +3     
============================================
  Files            25       25              
  Lines           508      518      +10     
  Branches         15       15              
============================================
+ Hits            372      378       +6     
- Misses          128      131       +3     
- Partials          8        9       +1     
Impacted Files Coverage Δ
src/main/java/org/opensearch/sdk/SDKClient.java 80.00% <66.66%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dbwiddis
dbwiddis previously approved these changes Jan 6, 2023
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved (where I'll tweak it later) given your time constraints, but some suggestions I'd like handled if you have the time.

@owaiskazi19 owaiskazi19 force-pushed the high-level-client branch 2 times, most recently from 7bf6921 to 82ba7e2 Compare January 6, 2023 19:50
@joshpalis joshpalis merged commit 7ceebb7 into opensearch-project:main Jan 9, 2023
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* Added High Level Rest Client for SDK

Signed-off-by: Owais Kazi <[email protected]>

* Updates method name

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

* Implements Closeable for SDKClients

Signed-off-by: Owais Kazi <[email protected]>

Signed-off-by: Owais Kazi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants