Transport service #191
Merged
Transport service #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
mloufra
force-pushed
the
transportService
branch
from
ca16689 to
c654293
Compare
owaiskazi19
reviewed
Oct 12, 2022
owaiskazi19
reviewed
Oct 12, 2022
dbwiddis
reviewed
Oct 13, 2022
dbwiddis
previously approved these changes
Oct 13, 2022
Signed-off-by: mloufra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
============================================
- Coverage 66.66% 65.99% -0.68%
+ Complexity 106 105 -1
============================================
Files 25 25
Lines 495 497 +2
Branches 25 25
============================================
- Hits 330 328 -2
- Misses 149 152 +3
- Partials 16 17 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
owaiskazi19
approved these changes
Oct 13, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* handle transportService object Signed-off-by: mloufra <[email protected]> * fix merge conflict Signed-off-by: mloufra <[email protected]> * address comment Signed-off-by: mloufra <[email protected]> Signed-off-by: mloufra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra [email protected]
To avoid passing the object of
extensionRunnerinExtensionsRunnermain function, move all of the required methods and variables toNettyTransportfileAddress comment from previous PR.
Fixed the bind errors by moving the netty initialization out of the constructor in the Extensions Runner and backed out the "hack" solution from intervening PR.
Issues Resolved
#166
#116
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.