Added createComponent to Extension interface #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n abstract class Signed-off-by: Ryan Bogan <[email protected]>
|
Will review this after createComponent workflow is merged and integrated. |
dbwiddis
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Great start!
As you can see from my comments, you need to add the createComponents() to the interface and then implement (override) it here. You may not need all the same arguments as the plugins, but it's a reasonable start.
Then ExtensionsRunner will call this method during initialization, passing its own objects here.
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Show resolved
Hide resolved
src/test/java/org/opensearch/sdk/sample/helloworld/TestHelloWorldExtension.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
dbwiddis
reviewed
Sep 30, 2022
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
dbwiddis
previously approved these changes
Oct 6, 2022
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
…t#169) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <[email protected]> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <[email protected]> * Add a POST request to parse content Signed-off-by: Daniel Widdis <[email protected]> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <[email protected]> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <[email protected]> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
dbwiddis
requested changes
Oct 11, 2022
src/main/java/org/opensearch/sdk/sample/helloworld/HelloWorldExtension.java
Show resolved
Hide resolved
dbwiddis
reviewed
Oct 11, 2022
Signed-off-by: Ryan Bogan <[email protected]>
dbwiddis
approved these changes
Oct 11, 2022
owaiskazi19
reviewed
Oct 11, 2022
owaiskazi19
approved these changes
Oct 11, 2022
dbwiddis
force-pushed
the
main
branch
3 times, most recently
from
f2399fb to
6eab1a5
Compare
…ava into create_component_extension_interface
Closed
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Added createComponent to Extension interface and created BaseExtension abstract class Signed-off-by: Ryan Bogan <[email protected]> * Fixed minor error Signed-off-by: Ryan Bogan <[email protected]> * Changed create component arguments Signed-off-by: Ryan Bogan <[email protected]> * Addressed PR Comments Signed-off-by: Ryan Bogan <[email protected]> * Fixed minor errors Signed-off-by: Ryan Bogan <[email protected]> * Return consumed params and content from extensions (opensearch-project#169) * Remove duplicate copies of registries in handlers Signed-off-by: Daniel Widdis <[email protected]> * Move ExtensionRestResponse to OpenSearch Signed-off-by: Daniel Widdis <[email protected]> * Add a POST request to parse content Signed-off-by: Daniel Widdis <[email protected]> * Add a DELETE request corresponding to the POST Signed-off-by: Daniel Widdis <[email protected]> * Add consumed params and content to Extension Responses Signed-off-by: Daniel Widdis <[email protected]> * Update tests and OpenAPI spec Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> * Fixed minor errors Signed-off-by: Ryan Bogan <[email protected]> * Addressed PR Comments Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Bogan [email protected]
Description
Adds createComponent to Extension interface and createsBaseExtension abstract class
Note: This is dependent on getSettings, so it will remain a draft PR for now.
Issues Resolved
#136
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.