Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 to gemspec #218

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

shmokmt
Copy link
Contributor

@shmokmt shmokmt commented Dec 27, 2023

Description

  • Add base64 to gemspec, which is no longer the default gem from Ruby 3.4.
    • opensearch-ruby uses base64 gem in client.rb
❯ git grep "require 'base64'"
lib/opensearch/transport/client.rb:27:require 'base64'

References

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shmokmt shmokmt force-pushed the fix/base64-warning branch 2 times, most recently from b008c0b to 9f7e171 Compare December 27, 2023 04:45
@shmokmt shmokmt marked this pull request as ready for review December 27, 2023 04:53
dblock
dblock previously approved these changes Dec 27, 2023
opensearch-ruby.gemspec Outdated Show resolved Hide resolved
@nhtruong nhtruong merged commit 1171e52 into opensearch-project:main Dec 28, 2023
55 checks passed
@shmokmt shmokmt deleted the fix/base64-warning branch December 28, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants