Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsyncOpenSearch() parameter ssl_assert_hostname #843

Merged
merged 9 commits into from
Nov 16, 2024
Merged

Implement AsyncOpenSearch() parameter ssl_assert_hostname #843

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9c9692b
Implement AsyncOpenSearch() parameter `ssl_assert_hostname` to allow …
merlinz01 Nov 10, 2024
dff0bf8
Update PR link
merlinz01 Nov 10, 2024
4415da0
Add test
merlinz01 Nov 14, 2024
7752471
Update docs
merlinz01 Nov 14, 2024
5996efc
Add test for default value
merlinz01 Nov 14, 2024
1bc2c8e
Merge branch 'main' into implement-async-ssl_assert_hostname
dblock Nov 14, 2024
0a598d4
Fix formatting
merlinz01 Nov 14, 2024
7569dc4
Fix test failing on Python >3.12.7
merlinz01 Nov 15, 2024
227fbaa
Fix formatting
merlinz01 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
### Added
- Added `AsyncSearch#collapse` ([827](https://github.com/opensearch-project/opensearch-py/pull/827))
- Implement `ssl_assert_hostname` boolean parameter for `AsyncOpenSearch.__init__()` ([843](https://github.com/opensearch-project/opensearch-py/pull/843))
### Changed
### Deprecated
### Removed
Expand Down
3 changes: 2 additions & 1 deletion opensearchpy/_async/http_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def __init__(
client_cert: Any = None,
client_key: Any = None,
ssl_version: Any = None,
ssl_assert_hostname: bool = True,
ssl_assert_fingerprint: Any = None,
maxsize: Optional[int] = 10,
headers: Any = None,
Expand Down Expand Up @@ -177,7 +178,7 @@ def __init__(

if verify_certs:
ssl_context.verify_mode = ssl.CERT_REQUIRED
ssl_context.check_hostname = True
ssl_context.check_hostname = ssl_assert_hostname
else:
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE
Expand Down
Loading