Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2.11. #583

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Remove 2.11. #583

merged 1 commit into from
Nov 15, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 14, 2023

Description

Removing 2.11 because of #582. I am 99.9% sure this is not a client problem, see opensearch-project/OpenSearch#11024 (comment).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <[email protected]>
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1da810c) 71.87% compared to head (2b66f99) 71.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   71.87%   71.87%           
=======================================
  Files          89       89           
  Lines        7922     7922           
=======================================
  Hits         5694     5694           
  Misses       2228     2228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to remove it from COMPATIBILITY.md?

@dblock
Copy link
Member Author

dblock commented Nov 15, 2023

Do we also want to remove it from COMPATIBILITY.md?

No I think the test is wrong, but I don't know how to fix it.

@dblock dblock merged commit 4358034 into opensearch-project:main Nov 15, 2023
53 of 61 checks passed
@dblock dblock deleted the remove-2.11 branch November 15, 2023 03:53
dblock added a commit that referenced this pull request Nov 15, 2023
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
Signed-off-by: dblock <[email protected]>
Signed-off-by: roma2023 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants