Generate opensearch-py client from API specs #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 70.63% 71.08% +0.44%
==========================================
Files 83 83
Lines 7857 7756 -101
==========================================
- Hits 5550 5513 -37
+ Misses 2307 2243 -64
|
Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
merge/client
branch
from
0df0987 to
356bd96
Compare
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal and
florianvazelle
as code owners
dblock
approved these changes
Oct 26, 2023
| if all_paths_have_deprecation and x_deprecation_message is not None: | ||
| api.update({"deprecation_message": x_deprecation_message}) | ||
|
|
||
| if namespace == "indices" and name == "put_mapping": |
There was a problem hiding this comment.
Do you want to try to extract the JSON patch logic from my other PR after this, and we can discuss whether it's a good idea, or do you want me to do it?
There was a problem hiding this comment.
Consolidating all patches in one place within overrides is efficient. However, creating a completely new spec for those endpoints might risk becoming outdated and misaligned with the main spec.
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
Signed-off-by: saimedhi <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate all APIs
Issues Resolved
closes #489, #477
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.