Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue350/advanced action guide and sample #540

Conversation

Djcarrillo6
Copy link
Contributor

Description

Create advanced index actions guide & it's associated sample code file.

Issues Resolved

Resolves issue #350
When approved & merged, allows for the closure of this PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

OSCI-2023

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #540 (5edf6c0) into main (80b9681) will decrease coverage by 0.47%.
Report is 10 commits behind head on main.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   70.87%   70.40%   -0.47%     
==========================================
  Files          83       83              
  Lines        7790     7857      +67     
==========================================
+ Hits         5521     5532      +11     
- Misses       2269     2325      +56     
Files Coverage Δ
opensearchpy/_async/transport.py 86.36% <ø> (-0.65%) ⬇️
opensearchpy/_version.py 100.00% <100.00%> (ø)
opensearchpy/connection/base.py 93.66% <ø> (ø)
opensearchpy/connection/http_urllib3.py 86.02% <100.00%> (+0.30%) ⬆️
opensearchpy/connection_pool.py 89.09% <ø> (ø)
opensearchpy/helpers/utils.py 91.01% <ø> (ø)
opensearchpy/transport.py 91.56% <100.00%> (-0.46%) ⬇️
opensearchpy/_async/client/cat.py 65.78% <70.00%> (+1.90%) ⬆️
opensearchpy/client/cat.py 65.78% <70.00%> (+1.90%) ⬆️
opensearchpy/_async/client/cluster.py 51.76% <53.12%> (-3.41%) ⬇️
... and 1 more

... and 5 files with indirect coverage changes

Signed-off-by: Djcarrillo6 <[email protected]>

Updated CHANGELOG

Signed-off-by: Djcarrillo6 <[email protected]>

Updated CHANGELOG & link to sample.

Signed-off-by: Djcarrillo6 <[email protected]>

updated changelog (opensearch-project#522)

Signed-off-by: saimedhi <[email protected]>

Bump version to 2.3.2 (opensearch-project#524)

Signed-off-by: saimedhi <[email protected]>

Fix: typos. (opensearch-project#526)

* Fix: typo.

Signed-off-by: dblock <[email protected]>

* Fix: typo.

Signed-off-by: dblock <[email protected]>

* Fixed its.

Signed-off-by: dblock <[email protected]>

* Added Visual Code settings to .gitignore.

Signed-off-by: dblock <[email protected]>

* Added loop type for async client.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>

Modified generator to generate api deprecation warnings (opensearch-project#527)

Signed-off-by: saimedhi <[email protected]>

Generate cat client from API specs (opensearch-project#529)

Signed-off-by: saimedhi <[email protected]>

Generate cluster client from API specs (opensearch-project#530)

Signed-off-by: saimedhi <[email protected]>

Added new guide & sample module for using index templates. (opensearch-project#531)

Added index_template guide and sample

Signed-off-by: Djcarrillo6 <[email protected]>

Removed EOL Python3.5 & bumped urllib3 version to patch security vulnerability (opensearch-project#533)

Updated CHANGELOG with pull #

Updated CHANGELOG with pull #

Updated CHANGELOG removed section.

Updated CHANGELOG removed section again

Signed-off-by: Djcarrillo6 <[email protected]>

Align pool_maxsize for different connection pool implementations. (opensearch-project#535)

* Align pool_maxsize for different connection pool implementations.

Signed-off-by: dblock <[email protected]>

* Document connection classes and settings.

Signed-off-by: dblock <[email protected]>

* Undo change in async for backwards compatibility.

Signed-off-by: dblock <[email protected]>

* Fix: typo.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>

Add micro benchmarks. (opensearch-project#537)

* Align pool_maxsize for different connection pool implementations.

Signed-off-by: dblock <[email protected]>

* Added benchmarks.

Signed-off-by: dblock <[email protected]>

* Multi-threaded vs. async benchmarks.

Signed-off-by: dblock <[email protected]>

* Set pool size to the number of threads.

Signed-off-by: dblock <[email protected]>

* Added sync/async benchmark.

Signed-off-by: dblock <[email protected]>

* Report client-side latency.

Signed-off-by: dblock <[email protected]>

* Various updates to benchmarks, demonstrating threading improves throughput.

Signed-off-by: dblock <[email protected]>

* Bench info.

Signed-off-by: dblock <[email protected]>

* Fixup format.

Signed-off-by: dblock <[email protected]>

* Undo async maxsize.

Signed-off-by: dblock <[email protected]>

* Moved benchmarks folder.

Signed-off-by: dblock <[email protected]>

* Updated documentation and project description.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
@Djcarrillo6 Djcarrillo6 force-pushed the fix/issue350/advanced-action-guide-and-sample branch from 81d72ea to 5edf6c0 Compare October 14, 2023 00:25
@Djcarrillo6
Copy link
Contributor Author

@saimedhi Made a mistake when rebasing to a single commit, and it messed up my total files changed by a large amount. Reopening this PR with the clean branch

@Djcarrillo6 Djcarrillo6 deleted the fix/issue350/advanced-action-guide-and-sample branch October 14, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants