[CVE RISK] Upgrade urllib3 to v1.26.5 (for opensearch-benchmark #378) #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshathRaghav
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
=======================================
Coverage 70.86% 70.86%
=======================================
Files 83 83
Lines 7796 7796
=======================================
Hits 5525 5525
Misses 2271 2271
|
AkshathRaghav
changed the title
AkshathRaghav
changed the title
…t with the server and maintaining backward compatibility (opensearch-project#508) Signed-off-by: saimedhi <[email protected]> Signed-off-by: AkshathRaghav <[email protected]>
Signed-off-by: AkshathRaghav <[email protected]>
Signed-off-by: AkshathRaghav <[email protected]>
|
Looks like this PR brought it another unintended change with client generation. @AkshathRaghav you should work on branches, seeing that you work off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue was discovered in urllib3 before 1.26.5: when provided with a URL containing many @ characters in the authority component, the authority regular expression exhibits catastrophic backtracking, causing a denial of service if a URL were passed as a parameter or redirected to via an HTTP redirect.
Issues Resolved
This change increments the required urllib3 package in
setup.pyfor that purpose.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.