Added restore API in RemoteStoreClient #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 71.49% 71.29% -0.20%
==========================================
Files 81 83 +2
Lines 7668 7682 +14
==========================================
- Hits 5482 5477 -5
- Misses 2186 2205 +19
|
saimedhi
force-pushed
the
add/remote_store_client
branch
from
5e4c5cd to
d6010f0
Compare
Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
add/remote_store_client
branch
from
d6010f0 to
b8f38f2
Compare
|
The code is generated but shouldn't we have some tests for it to make sure it works at all? Maybe we can also take the habit of documenting this as part of these PRs in the user guides/adding working samples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added restore API in RemoteStoreClient. This is an experimental feature. API Code is generated using "python API generator". Tests to this feature can be added here
Issues Resolved
Related Issue #435
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.