-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin clients typing to the opensearch client #440
Add plugin clients typing to the opensearch client #440
Conversation
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 81 81
Lines 7668 7668
=======================================
Hits 5482 5482
Misses 2186 2186 |
Signed-off-by: florian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, update CHANGELOG?
Is there anything we can do to test this in a way that we don't forget next time?
Hello @florianvazelle, please respond to the following #399 (comment). Thanks |
@florianvazelle, Could you please finish this PR when you have a moment? Thank you! |
Hi @saimedhi, sorry I'm taking some time to study solutions to have a correct stubs package. The only real way I've found is to use stubtest, but that only ensures that the definitions in the stubs package are defined in the package at runtime too (no extra definitions) and logical with what is defined in the package at runtime (same parameters ...), but if a definition is missing in the stubs package it won't be raised. I'm going to add this to the linting commands anyway. To prevent oversights from happening again, I suggest opening a new issue to study solutions, and we'll can then merge this PR. |
@florianvazelle I finished #536 so types are back in the game. Do you want to finish this? I am not sure we need to declare types like this here. For other types we just do |
Did I? This code says
|
Description
I add the clients of the various plugins to the typing of the main client (
OpenSearch
).