Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI][GUIDE] Added Guide for Snapshot API(snapshot.md) #429

Closed
wants to merge 5 commits into from

Conversation

roma2023
Copy link
Contributor

@roma2023 roma2023 commented Jul 5, 2023

Description

Added Snapshot Actions Guide (guides/snapshot.md) with code examples

Issues Resolved

issue #406 resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Jul 5, 2023

Needs actual content in snapshot.md :)

@roma2023
Copy link
Contributor Author

roma2023 commented Jul 5, 2023

Ohhh I see, the changes weren't properly saved. It's fixed now!

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #429 (1d33f02) into main (2e8d5ce) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   70.87%   71.42%   +0.54%     
==========================================
  Files          81       81              
  Lines        7664     7667       +3     
==========================================
+ Hits         5432     5476      +44     
+ Misses       2232     2191      -41     

see 2 files with indirect coverage changes

roma2023 added 2 commits July 5, 2023 17:08
Signed-off-by: Raman Saparkhan <[email protected]>
Signed-off-by: Raman Saparkhan <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link this from somewhere?

@roma2023
Copy link
Contributor Author

roma2023 commented Jul 6, 2023

Maybe we can add a link in USER_GUIDE.md as well as links to other guides

@wbeckler
Copy link
Contributor

@roma2023 feel free to add those links

@roma2023
Copy link
Contributor Author

So, I am going to update USER_GUIDE.md, should I open a new PR for it to specify the change?

@dblock
Copy link
Member

dblock commented Jul 13, 2023

So, I am going to update USER_GUIDE.md, should I open a new PR for it to specify the change?

Do it part of this PR!

Signed-off-by: Raman Saparkhan <[email protected]>
@dblock
Copy link
Member

dblock commented Jul 26, 2023

Sorry for being late to this, let's finish it? We've done some reorganizing, so rebase this change please. I also added working samples to samples, want to add a working piece of code into this PR?

@roma2023
Copy link
Contributor Author

Yes, let's finish this. I can use working pieces of the 'Hello World' sample.

@saimedhi
Copy link
Collaborator

@roma2023, Could you please make the requested changes when you have a moment? Thank you!

@roma2023
Copy link
Contributor Author

roma2023 commented Sep 5, 2023

Please check new PR #486 and let's finish this task. I apologize for the delay.

@saimedhi saimedhi closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants