Support inclusive #65
Conversation
There was a problem hiding this comment.
Thank you @shyim for adding these changes!
There are some more references in https://github.com/opensearch-project/opensearch-php/blob/main/tests/Connections/ConnectionTest.php. Can we replace them as well?
|
Sure I will look later :) |
shyim
force-pushed
the
support-inclusive
branch
6 times, most recently
from
6e25b66 to
4c4beb1
Compare
|
@dblock @saratvemulapalli review please? |
There was a problem hiding this comment.
Will this code stop working against older versions of OpenSearch? It looks like it. In order to ensure the client is compatible with at least two major versions and thus allow a migration path, I think we need to deprecate functionality in 1 major release, then remove it in the next major release. So I think in this change we cannot throw errors, we need to log a warning for the deprecation.
shyim
force-pushed
the
support-inclusive
branch
2 times, most recently
from
1baf3d8 to
5c60d7c
Compare
Signed-off-by: Soner Sayakci <[email protected]>
Signed-off-by: Soner Sayakci <[email protected]>
Signed-off-by: Soner Sayakci <[email protected]>
|
@shyim See my question above though, what's the definite answer? |
|
@dblock ohh I didn't see that. The old parameter will be still send, but throws just a deprecation with the replacement :) |
|
Ok, I think this works. |
* feat: add cluster manager api Signed-off-by: Soner Sayakci <[email protected]> * feat: deprecate master_timeout Signed-off-by: Soner Sayakci <[email protected]> * feat: update all comments Signed-off-by: Soner Sayakci <[email protected]> Signed-off-by: Soner Sayakci <[email protected]> Signed-off-by: joanna.bak <[email protected]>
Description
Add inclusive names
Issues Resolved
#61
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.