Fix example in USER_GUIDE.md #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SQL example the `INDEX_NAME` constant was interpreted as a string literal. Signed-off-by: Tim Düsterhus <[email protected]>
TimWolla
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
shyim
approved these changes
Jun 13, 2024
|
Thank you! |
|
@TimWolla it would be great to have this and other samples as running code like in https://github.com/opensearch-project/opensearch-py/tree/main/samples. Maybe you'd be interested in taking that up? |
I'm afraid, there's too much on my plate already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the SQL example the
INDEX_NAMEconstant was interpreted as a string literal.Issues Resolved
None, this is a trivial change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.