Redo sniffing connection pool tests #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdhemy
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
imdhemy
force-pushed
the
fix-sniffing-connection-pool-tests
branch
from
308288f to
ca6a2f7
Compare
shyim
reviewed
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
============================================
+ Coverage 25.99% 26.97% +0.98%
+ Complexity 2018 2017 -1
============================================
Files 263 263
Lines 7145 7144 -1
============================================
+ Hits 1857 1927 +70
+ Misses 5288 5217 -71 ☔ View full report in Codecov by Sentry. |
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
Signed-off-by: imdhemy <[email protected]>
imdhemy
force-pushed
the
fix-sniffing-connection-pool-tests
branch
from
848dbfb to
211a328
Compare
|
I think LinkChecker started breaking and needs an upgrade, maybe someone can take care of it separately. |
|
@shyim all yours to review/merge |
shyim
approved these changes
Feb 29, 2024
dblock
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Redos the skipped tests of the Sniffing connection pool.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.